Skip to content
This repository has been archived by the owner on Apr 12, 2021. It is now read-only.

Improve clarity of chainID recovery logic #243

Open
karlfloersch opened this issue Feb 23, 2021 · 1 comment
Open

Improve clarity of chainID recovery logic #243

karlfloersch opened this issue Feb 23, 2021 · 1 comment
Labels
Category: Enhancement New feature or request Good First Issue

Comments

@karlfloersch
Copy link
Contributor

karlfloersch commented Feb 23, 2021 •
edited by maurelian
Loading

It's currently non-obvious where the chainID gets populated / decoded. We should make sure that that tx flow is as simple as possible / at minimum add better comments for how it works.
@karlfloersch karlfloersch added the Category: Enhancement New feature or request label Feb 23, 2021
@karlfloersch karlfloersch changed the title Refactor chainID recovery logic to improve clarity Improve clarity of chainID recovery Feb 23, 2021
@karlfloersch karlfloersch changed the title Improve clarity of chainID recovery Improve clarity of chainID recovery logic Feb 23, 2021
@platocrat platocrat mentioned this issue Mar 3, 2021
Closed
1 task
@smartcontracts
Copy link
Collaborator

Would be fixed by #300

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Category: Enhancement New feature or request Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Clarifying comments for chainID recovery logic platocrat/contracts
3 participants
@karlfloersch @smartcontracts @maurelian