Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geth RPC does not return revert reason when transaction reverts #484

Closed
platocrat opened this issue Apr 18, 2021 · 1 comment
Closed

Geth RPC does not return revert reason when transaction reverts #484

platocrat opened this issue Apr 18, 2021 · 1 comment
Labels
A-ops Area: ops C-bug Category: bugs

Comments

@platocrat
Copy link
Contributor

Describe the bug
When testing for whether an OVM-based transaction will revert, the transaction will revert without the expected error message being thrown. Instead, the following error message is returned from L2 geth.

To Reproduce
Steps to reproduce the behavior:

  1. Git clone Waffle or Truffle repository
  2. Yarn install, yarn compile for the OVM, and run tests
  3. For Waffle, see all but the last 2 reversion tests pass, and for Truffle, see no tests pass since contract deployment fails with insufficient gas error.

Expected behavior
If the transaction fails, L2 geth should get the revert reason returned from the contract instead of throwing an estimate gas error.

Screenshots
Screen Shot 2021-04-17 at 7 59 58 PM

@platocrat platocrat added A-geth C-bug Category: bugs A-ops Area: ops labels Apr 18, 2021
@snario snario changed the title bug: Error: cannot estimate gas; transaction may fail or may require manual gas limit Geth RPC does not return revert reason when transaction reverts Apr 18, 2021
@snario
Copy link
Contributor

snario commented Apr 18, 2021

I think this is a duplicate issue with #474?

bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this issue Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ops Area: ops C-bug Category: bugs
Projects
None yet
Development

No branches or pull requests

2 participants