Merge pull request #208 from ethereum-optimism/harry/fix_forked_logging

feat: fix logging flag for supersim in fork mode

anvil/anvil.go

@@ -135,6 +135,7 @@ func (a *Anvil) Start(ctx context.Context) error {
 
 		logFile = tempLogFile
 		// Clean up the temp log file
+		// TODO (https://github.com/ethereum-optimism/supersim/issues/205) This results in the temp file being deleted right away instead of after shutdown.
 		defer a.removeFile(logFile)
 	} else {
 		// Expand the path to the log file

orchestrator/fork.go

@@ -17,7 +17,8 @@ import (
 
 const blockTime = 2
 
-func NetworkConfigFromForkCLIConfig(log log.Logger, envPrefix string, forkConfig *config.ForkCLIConfig) (config.NetworkConfig, error) {
+func NetworkConfigFromForkCLIConfig(log log.Logger, envPrefix string, cliConfig *config.CLIConfig) (config.NetworkConfig, error) {
+	forkConfig := cliConfig.ForkConfig
 	superchain := registry.Superchains[forkConfig.Network]
 	networkConfig := config.NetworkConfig{InteropEnabled: forkConfig.InteropEnabled}
 
@@ -54,6 +55,7 @@ func NetworkConfigFromForkCLIConfig(log log.Logger, envPrefix string, forkConfig
 		Name:          forkConfig.Network,
 		ChainID:       superchain.Config.L1.ChainID,
 		SecretsConfig: config.DefaultSecretsConfig,
+		LogsDirectory: cliConfig.LogsDirectory,
 		ForkConfig: &config.ForkConfig{
 			RPCUrl:      l1RpcUrl,
 			BlockNumber: l1Header.Number.Uint64(),
@@ -95,6 +97,7 @@ func NetworkConfigFromForkCLIConfig(log log.Logger, envPrefix string, forkConfig
 			Name:          chainCfg.Chain,
 			ChainID:       chainCfg.ChainID,
 			SecretsConfig: config.DefaultSecretsConfig,
+			LogsDirectory: cliConfig.LogsDirectory,
 			ForkConfig: &config.ForkConfig{
 				RPCUrl:      l2RpcUrl,
 				BlockNumber: l2ForkHeight,

supersim.go

@@ -32,7 +32,7 @@ func NewSupersim(log log.Logger, envPrefix string, closeApp context.CancelCauseF
 		log.Info("generating fork configuration", "superchain", superchain.Superchain)
 
 		var err error
-		networkConfig, err = orchestrator.NetworkConfigFromForkCLIConfig(log, envPrefix, cliConfig.ForkConfig)
+		networkConfig, err = orchestrator.NetworkConfigFromForkCLIConfig(log, envPrefix, cliConfig)
 		if err != nil {
 			return nil, fmt.Errorf("failed to construct fork configuration: %w", err)
 		}