Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated documentation #246

Open
Ethanol48 opened this issue Nov 2, 2024 · 1 comment
Open

Outdated documentation #246

Ethanol48 opened this issue Nov 2, 2024 · 1 comment
Assignees
@jakim929
Labels
documentation Improvements or additions to documentation prioritized

Comments

@Ethanol48
Copy link
Contributor

Ethanol48 commented Nov 2, 2024 •
edited
Loading

I stumbled upon an outdated / deprecated piece of code in the docs and resolved it proposing the method showned in the video presentation for more info #245.

Looking more around the docs in these pages:

https://supersim.pages.dev/chain-environment/network-details/op-chain-a
https://supersim.pages.dev/chain-environment/network-details/op-chain-b

The contracts for the OptimismPortal are wrong (at the time of the writting).

they should be 0x37a418800d0c812A9dE83Bc80e993A6b76511B57 and 0x35e67BC631C327b60C6A39Cff6b03a8adBB19c2D respectively

I also noticed this problem for these different contracts: L1CrossDomainMessenger L1StandardBridge I'm not sure if there are more contracts with this problem.
@jakim929 jakim929 added the documentation Improvements or additions to documentation label Nov 5, 2024
@jakim929
Copy link
Contributor

jakim929 commented Nov 5, 2024

thank you for the report! - will fix this

@jakim929 jakim929 self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakim929 jakim929

Labels
documentation Improvements or additions to documentation prioritized
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakim929 @Ethanol48