Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adds interop delay option #255

Merged
merged 8 commits into from
Nov 13, 2024

Conversation

tabshaikh
Copy link
Contributor

@tabshaikh tabshaikh commented Nov 9, 2024

Description

  • by default the inclusiondelay is false
  • adds --interop.inclusiondelay flag in cli which delays sent messages by 5 seconds

Todo:

  • write tests
  • update documentation

Metadata

#133

@tabshaikh tabshaikh requested a review from a team as a code owner November 9, 2024 03:46
@tabshaikh tabshaikh mentioned this pull request Nov 9, 2024
1 task
@jakim929
Copy link
Contributor

discussed on tg: decided that it be better to include this logic in opsimulator rather than indexer

config/cli.go Outdated Show resolved Hide resolved
@@ -71,6 +72,12 @@ func BaseCLIFlags(envPrefix string) []cli.Flag {
Value: "",
EnvVars: opservice.PrefixEnvVar(envPrefix, "LOGS_DIRECTORY"),
},
&cli.Uint64Flag{
Name: InteropDelayFlagName,
Value: 0, // enabled by default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove comment

Copy link
Contributor

@jakim929 jakim929 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! one nit for comment left but not super important. ready to go once CI passes

@jakim929 jakim929 merged commit 5d08fc0 into ethereum-optimism:main Nov 13, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants