You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current logic for a FINDNODES message is that the response may be spread across multiple messages. If any of these messages fail to be delivered our implementation will drop all of the responses and treat it as a timeout.
How can it be fixed?
An alternate approach would be to return whatever messages we receive, even if all messages are not received since they will contain a subset of the the requested ENR records.
Care should be taken to ensure that there aren't undefined behaviors or security concerns in this approach.
The text was updated successfully, but these errors were encountered:
What was wrong?
inspired by: https://github.com/ethereum/ddht/pull/122/files/a1238887112f663e6c46696e3f0937bb3bd3df7a#r509003163
The current logic for a FINDNODES message is that the response may be spread across multiple messages. If any of these messages fail to be delivered our implementation will drop all of the responses and treat it as a timeout.
How can it be fixed?
An alternate approach would be to return whatever messages we receive, even if all messages are not received since they will contain a subset of the the requested ENR records.
Care should be taken to ensure that there aren't undefined behaviors or security concerns in this approach.
The text was updated successfully, but these errors were encountered: