Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change compile to take in a JS object rather than a string. #358

Open
MicahZoltu opened this issue May 5, 2019 · 0 comments
Open

Change compile to take in a JS object rather than a string. #358

MicahZoltu opened this issue May 5, 2019 · 0 comments
Labels

Comments

@MicahZoltu
Copy link
Contributor

MicahZoltu commented May 5, 2019

The compile function takes in a string, when really it wants a well described JS object. In JS, this isn't much of a difference but when using something like TypeScript or Flow the difference is pretty significant as one gives you compile-time errors/warnings and auto-complete while the other (string input) gives you nothing useful.

An initial pass at the TS definitions can be found at https://github.com/MicahZoltu/solc-js/blob/ts-definitions/index.d.ts and discussion can be found at #205.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants