Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fill): explain how to verify fixture refactors via hasher #1442

Open
danceratopz opened this issue Feb 5, 2025 · 1 comment
Open

docs(fill): explain how to verify fixture refactors via hasher #1442

danceratopz opened this issue Feb 5, 2025 · 1 comment

Comments

@danceratopz
Copy link
Member

Add something along the lines of the following which was taken from ethereum/execution-spec-tests#1170 (review)


For future reference, here's how I verified fixtures locally:

Fill with your branch: with flag rm -rf fixtures-1170/; fill --fork Shanghai tests/shanghai/eip3860_initcode/test_initcode.py ----output=fixtures-1170
Fill with main: rm -rf fixtures-main/; fill --fork Shanghai tests/shanghai/eip3860_initcode/test_initcode.py ----output=fixtures-main
Run hasher on both output dirs:

uv run hasher fixtures-1170 > after.txt
uv run hasher fixtures-main > before.txt

Diff hasher output:

diff before.txt after.txt
@winsvega
Copy link
Collaborator

winsvega commented Feb 6, 2025

can there be one command. like in this test repo there is a CI running
-t GeneralStateTests --checkhash

and it verifies that all the generated tests have a corresponding filler hash in their header at the time of generation.
so if anyone commit outdated test which source filler is of a newer version it will yell an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants