Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo: Simplify coverage Command & Reactivate Reporting #3789

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

holgerd77
Copy link
Member

This simplifies the coverage runs by removing the c8 tool usage and directly use the in-build vitest coverage functionality.

Beside being simpler goal is to reactivate coverage reporting for certain packages.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.85%. Comparing base (0440d5b) to head (59cc62c).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.25% <ø> (ø)
client 74.01% <ø> (+74.01%) ⬆️
common 89.89% <ø> (ø)
devp2p 71.95% <ø> (ø)
evm 64.89% <ø> (ø)
genesis 100.00% <ø> (ø)
mpt 52.19% <ø> (+0.10%) ⬆️
rlp 95.11% <ø> (?)
statemanager 68.94% <ø> (ø)
tx 76.70% <ø> (ø)
util 72.78% <ø> (ø)
vm 57.37% <ø> (ø)
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member Author

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should clean these things up a bit at some point (not urgent! focus on your Devcon stuff!! 😋), so decide what to do with coverage.sh (still needed?), also align coverage commands, but I guess we can take in for now, coverage increase seems to be working?

Will do by admin-merge (own PR continued).

@holgerd77 holgerd77 merged commit 253e271 into master Nov 7, 2024
41 checks passed
@holgerd77 holgerd77 deleted the monorepo-remove-c8-from-coverage branch November 7, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants