New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the naming of function PolicyFlowDefault.underwrite() is misleading #109

Open

matthiaszimmermann opened this issue Jun 1, 2023 · 0 comments

Contributor

matthiaszimmermann commented Jun 1, 2023

what one might expect the function does:

check if there is sufficient risk capital in the risk pool
block the right amount of risk capital
set application to underwritten
create a policy

what the function does:

all the above
collect premiums if possible

possible ways to improve over current state

rename function to something less misleading
remove premium collection from function scope
... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment