Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

releasePolicy issues #114

Open
rapidddenis opened this issue Jun 16, 2023 · 0 comments
Open

releasePolicy issues #114

rapidddenis opened this issue Jun 16, 2023 · 0 comments

Comments

@rapidddenis
Copy link

rapidddenis commented Jun 16, 2023 •
edited
Loading

gif-contracts/contracts/modules/BundleController.sol

Lines 239 to 242 in b58fd27

function releasePolicy(uint256 bundleId, bytes32 processId)
external override
onlyRiskpoolService
returns(uint256 remainingCollateralAmount)

  1. remainingCollateralAmount is initialised implicitly, function always returns 0
  2. no check for bundleId <-> processId correspondence. It is possible to proceed with processId of bundle[differentBundleId] and decrease active policies of bundle[bundelId] while releasing 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rapidddenis