Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master instance should not be registered as regular instance #497

Open
doerfli opened this issue Jul 15, 2024 · 2 comments
Open

Master instance should not be registered as regular instance #497

doerfli opened this issue Jul 15, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@doerfli
Copy link
Contributor

doerfli commented Jul 15, 2024

use own nft type instead of instance. so it does not mix with regular instances and can be easily distinguished.

@doerfli doerfli added enhancement New feature or request nft instance labels Jul 15, 2024
@doerfli doerfli added this to the GIF v3 Audit Ready milestone Jul 15, 2024
@marcoatpaladin
Copy link
Collaborator

It looks like right now the InstanceService hardcodes these instances and does not use the registry. To my knowledge no other component uses the registry for the master instances.

The master instances could thus be dropped from the registry alltogether, or at least be kept in their own namespace within the registry, as they represent a different concept to the real instances.

@doerfli doerfli added the review label Jul 17, 2024
@matthiaszimmermann matthiaszimmermann self-assigned this Sep 11, 2024
@rapidddenis
Copy link
Collaborator

Also initialization of master instance can be made minimal (e.g. without access control configuration)

@doerfli doerfli modified the milestones: GIF v3 Audit Ready, GIF v3 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants