Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer refering to external contracts by their interface over their implementation #503

Open
marcoatpaladin opened this issue Jul 15, 2024 · 0 comments

Comments

@marcoatpaladin
Copy link
Collaborator

ReleaseRegistry public _releaseRegistry;

Throughout the codebase, the actual implementation type is often used to type external contracts. It's cleaner to use the interface type instead. This more clearly documents that its actually that "interface" which is being used and needed here, as the contract in question is allowed to differ from the specific contract version you compiled with.

This is informational as this is syntax sugar, and does not affect anything at the lower level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants