Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas optimisation Authz #659

Open
Tracked by #594
doerfli opened this issue Sep 3, 2024 · 1 comment
Open
Tracked by #594

Gas optimisation Authz #659

doerfli opened this issue Sep 3, 2024 · 1 comment

Comments

@doerfli
Copy link
Contributor

doerfli commented Sep 3, 2024

Check if its possible to improve the gas consumption for canCallWithDelay. Currently every call to this method uses ~14k gas. Since this is often done multiple times during an operation, an improvement to this could improve overall gas consumption.

this is an example gas analysis from tx https://amoy.polygonscan.com/tx/0xc85256c6980d7c30ec633892906c51d38d800e24b18a1c7704cc63b2f9e25cd5

Cursor_and_basetest___Tenderly

Load in tenderly for details.

@doerfli
Copy link
Contributor Author

doerfli commented Sep 3, 2024

~3k gas could be saved when the global lock is not checked (https://github.com/etherisc/gif-next/blob/develop/contracts/authorization/AccessManagerCloneable.sol#L100), but that would mean sacrificing this feature.
The rest of the execution is within the openzeppelin scope.

@doerfli doerfli removed this from the GIF v3 Audit Ready milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant