From 31efa2d7ba80376d7c38c6beefb700c7fc2d1c58 Mon Sep 17 00:00:00 2001 From: Ljubisa Date: Mon, 1 Jul 2024 13:17:56 +0200 Subject: [PATCH] chore: modify comments about possible improvements --- pkg/api/peer.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/api/peer.go b/pkg/api/peer.go index 9fabda66989..51884348ccf 100644 --- a/pkg/api/peer.go +++ b/pkg/api/peer.go @@ -137,7 +137,8 @@ func (s *Service) blocklistPeerHandler(w http.ResponseWriter, r *http.Request) { return } - // TODO: create custom validator for swarm.Address + // TODO: create custom validator for swarm.Address using go-playground/validator and use it here to validate the struct. + // Validator should be initialized in the service constructor of mocks as well. if !payload.Address.IsValidNonEmpty() { logger.Debug("peer address is not valid") logger.Error(nil, "peer address is not valid") @@ -145,6 +146,7 @@ func (s *Service) blocklistPeerHandler(w http.ResponseWriter, r *http.Request) { return } + // TODO: possible to extend Blocklist method to return actual Duration value in jsonhttp response if err := s.p2p.Blocklist(payload.Address, payload.Duration, payload.Reason); err != nil { logger.Debug("blocklist peer failed", "peer_address", payload.Address, "error", err) if errors.Is(err, p2p.ErrPeerNotFound) {