Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trx recipients in bee to catch errors #4364

Closed
nikipapadatou opened this issue Oct 2, 2023 · 1 comment · Fixed by #4367
Closed

trx recipients in bee to catch errors #4364

nikipapadatou opened this issue Oct 2, 2023 · 1 comment · Fixed by #4367
Assignees
Labels

Comments

@nikipapadatou
Copy link
Collaborator

nikipapadatou commented Oct 2, 2023

Atm bee nodes are not catching properly outputs of errors/reverts and although we catch the revert status, we do not catch the reason. (

return fmt.Errorf("claiming win: %w", err)
)

An example of error on goerli, and we need to see how to do this with the bee nodes as well:
https://goerli.etherscan.io/tx/0x74a2577db1c325c41e38977aa1eb32ab03dfa17cc1fa0649e84f3d8c0f0882ee

Let's proceed with this so that we know why functions are failing.

@0xCardinalError
Copy link

I would give more context to this. So this was discussed here
#4358

and there is a link to docs about custom errors from solidity with revert statement
https://docs.soliditylang.org/en/latest/control-structures.html#revert

This link also might help as it explains the basics of it.
https://soliditylang.org/blog/2021/04/21/custom-errors/

I couldn't find any golang solutions but there is JS/TS library here https://github.com/superical/ethers-decode-error
that solves this so some logic could be modeled on it.
@mrekucci @acha-bill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants