Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests for NewOverlayFromEthereumAddress method #4485

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions pkg/crypto/crypto_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (

"github.com/ethereum/go-ethereum/common"
"github.com/ethersphere/bee/pkg/crypto"
"github.com/ethersphere/bee/pkg/swarm"
)

func TestGenerateSecp256k1Key(t *testing.T) {
Expand Down Expand Up @@ -252,3 +253,60 @@ func TestNewEthereumAddress(t *testing.T) {
t.Fatalf("address mismatch %x %x", address, expectAddress)
}
}

func TestNewOverlayFromEthereumAddress(t *testing.T) {
t.Parallel()

testCases := []struct {
wantAddress swarm.Address
Aviksaikat marked this conversation as resolved.
Show resolved Hide resolved
overlayID uint64
hash []byte
expectedAddress string
Aviksaikat marked this conversation as resolved.
Show resolved Hide resolved
}{
{
wantAddress: swarm.MustParseHexAddress("1815cac638d1525b47f848daf02b7953e4edd15c"),
overlayID: 1,
hash: common.HexToHash("0x1").Bytes(),
expectedAddress: "a38f7a814d4b249ae9d3821e9b898019c78ac9abe248fff171782c32a3849a17",
},
{
wantAddress: swarm.MustParseHexAddress("1815cac638d1525b47f848daf02b7953e4edd15c"),
overlayID: 1,
hash: common.HexToHash("0x2").Bytes(),
expectedAddress: "c63c10b1728dfc463c64c264f71a621fe640196979375840be42dc496b702610",
},
{
wantAddress: swarm.MustParseHexAddress("d26bc1715e933bd5f8fad16310042f13abc16159"),
overlayID: 2,
hash: common.HexToHash("0x1").Bytes(),
expectedAddress: "9f421f9149b8e31e238cfbdc6e5e833bacf1e42f77f60874d49291292858968e",
},
{
wantAddress: swarm.MustParseHexAddress("ac485e3c63dcf9b4cda9f007628bb0b6fed1c063"),
overlayID: 1,
hash: common.HexToHash("0x0").Bytes(),
expectedAddress: "fe3a6d582c577404fb19df64a44e00d3a3b71230a8464c0dd34af3f0791b45f2",
},
}

for _, tc := range testCases {

gotAddress, err := crypto.NewOverlayFromEthereumAddress(tc.wantAddress.Bytes(), tc.overlayID, tc.hash)
if err != nil {
t.Fatal(err)
}

if l := len(gotAddress.Bytes()); l != swarm.HashSize {
t.Errorf("got address length %v, want %v", l, swarm.HashSize)
}

wantAddress, err := swarm.ParseHexAddress(tc.expectedAddress)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step can be avoided by using swarm.MustParseHexAddress function in the test table.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only line 303 or from 299?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because MustParseHexAddress is not taking account of the length of the hash

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the tc.expectedAddress.

if err != nil {
t.Fatal(err)
}

if !wantAddress.Equal(gotAddress) {
t.Errorf("Expected %s, but got %s", wantAddress, gotAddress)
Aviksaikat marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
Loading