Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.10.1 and 1.10.2 have wrong java 9 module descriptor #33

Open
aleruz-dt opened this issue Jul 25, 2024 · 2 comments
Open

Version 1.10.1 and 1.10.2 have wrong java 9 module descriptor #33

aleruz-dt opened this issue Jul 25, 2024 · 2 comments

Comments

@aleruz-dt
Copy link

While version 1.10.0 has

module com.ethlo.time {
    exports com.ethlo.time;
}

as module descriptor, version 1.10.1 and 1.10.2 has

module com.ethlo.time {
    exports com.ethlo.time.token;
}

and this breaks the usage of the library in combination, for example, with json-schema-validator

Forcing the usage of version 1.10.0 makes it work again.

ethlo pushed a commit that referenced this issue Jul 25, 2024
ethlo added a commit that referenced this issue Jul 25, 2024
Co-authored-by: Morten Haraldsen <[email protected]>
@ethlo
Copy link
Owner

ethlo commented Jul 25, 2024

I have no experience with how the OSGI modules should be packaged. I get a warning that there is a private reference to the package com.ethlo.time.token after this change.

@aleruz-dt
Copy link
Author

I can try it, if you publish a version, maybe better a RC.
To verify locally, you can check the module-info.java file present in the META-INF/versions/9 directory.

I have no experience with the maven plugins you are using, so I can't help there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants