fix(exe): Reset web3_client_version when version changes

ethpandaops · Aug 14, 2024 · 01a4acb · 01a4acb
1 parent 8a207d6
commit 01a4acb
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/pkg/exporter/execution/jobs/web3.go b/pkg/exporter/execution/jobs/web3.go
@@ -13,11 +13,12 @@ import (
 
 // Web3 exposes metrics defined by the Web3 module.
 type Web3 struct {
-	client        *ethclient.Client
-	api           api.ExecutionClient
-	ethRPCClient  *ethrpc.EthRPC
-	log           logrus.FieldLogger
-	ClientVersion prometheus.GaugeVec
+	client          *ethclient.Client
+	api             api.ExecutionClient
+	ethRPCClient    *ethrpc.EthRPC
+	log             logrus.FieldLogger
+	ClientVersion   prometheus.GaugeVec
+	previousVersion string
 }
 
 const (
@@ -76,6 +77,12 @@ func (w *Web3) tick(ctx context.Context) {
 	if err != nil {
 		w.log.WithError(err).Error("Failed to get node info")
 	} else {
-		w.ClientVersion.WithLabelValues(clientVersion).Set(1)
+		if w.previousVersion != clientVersion {
+			w.ClientVersion.Reset()
+
+			w.ClientVersion.WithLabelValues(clientVersion).Set(1)
+		}
+
+		w.previousVersion = clientVersion
 	}
 }