fix MonitorExecution.started bug (#5864)

Author: adamsachs

CHANGELOG.md

@@ -40,6 +40,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
 ### Fixed
 - Fixed pagination bugs on some tables [#5819](https://github.com/ethyca/fides/pull/5819)
 - Fixed load_samples to wrap variables in quotes to prevent YAML parsing errors [#5857](https://github.com/ethyca/fides/pull/5857)
+- Fixed incorrect value being set for `MonitorExecution.started` column [#5864](https://github.com/ethyca/fides/pull/5864)
 
 ## [2.56.2](https://github.com/ethyca/fides/compare/2.56.1...2.56.2)
 

src/fides/api/alembic/migrations/versions/1152c1717849_fix_monitorexecution_started_default.py

@@ -0,0 +1,57 @@
+"""fix monitorexecution.started default
+
+Revision ID: 1152c1717849
+Revises: 3c58001ad310
+Create Date: 2025-03-10 16:04:57.104689
+
+"""
+
+import sqlalchemy as sa
+from alembic import op
+from sqlalchemy.dialects import postgresql
+
+# revision identifiers, used by Alembic.
+revision = "1152c1717849"
+down_revision = "3c58001ad310"
+branch_labels = None
+depends_on = None
+
+
+def upgrade():
+    # Set the new server default
+    # And set the datetime to be timezone aware
+    op.alter_column(
+        "monitorexecution",
+        "started",
+        existing_type=sa.DateTime(),
+        type_=sa.DateTime(timezone=True),
+        server_default=sa.text("now()"),
+    )
+
+    # Set the datetime to be timezone aware
+    op.alter_column(
+        "monitorexecution",
+        "completed",
+        existing_type=sa.DateTime(),
+        type_=sa.DateTime(timezone=True),
+    )
+
+
+def downgrade():
+    # Remove the server default
+    # And set the datetime to not be timezone aware
+    op.alter_column(
+        "monitorexecution",
+        "started",
+        server_default=None,
+        existing_type=sa.DateTime(timezone=True),
+        type_=sa.DateTime(),
+    )
+
+    # Set the datetime to not be timezone aware
+    op.alter_column(
+        "monitorexecution",
+        "completed",
+        existing_type=sa.DateTime(timezone=True),
+        type_=sa.DateTime(),
+    )

src/fides/api/db/base.py

@@ -4,6 +4,7 @@
 from fides.api.db.base_class import Base
 from fides.api.models.application_config import ApplicationConfig
 from fides.api.models.asset import Asset
+from fides.api.models.attachment import Attachment, AttachmentReference
 from fides.api.models.audit_log import AuditLog
 from fides.api.models.authentication_request import AuthenticationRequest
 from fides.api.models.client import ClientDetail

src/fides/api/models/detection_discovery.py

@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from datetime import datetime, timezone
+from datetime import datetime
 from enum import Enum
 from typing import Any, Dict, Iterable, List, Optional, Type
 
@@ -388,7 +388,9 @@ class MonitorExecution(Base):
     )
     status = Column(String, nullable=True)
     started = Column(
-        DateTime(timezone=True), nullable=True, default=datetime.now(timezone.utc)
+        DateTime(timezone=True),
+        nullable=True,
+        server_default=func.now(),
     )
     completed = Column(DateTime(timezone=True), nullable=True)
     classification_instances = Column(

tests/ops/models/test_detection_discovery.py

@@ -10,6 +10,7 @@
 from fides.api.models.detection_discovery import (
     DiffStatus,
     MonitorConfig,
+    MonitorExecution,
     MonitorFrequency,
     StagedResource,
     fetch_staged_resources_by_type_query,
@@ -633,3 +634,50 @@ def test_update_monitor_config_execution_trigger_logic(
         )
         assert mc.execution_start_date == expected_date
         db.delete(mc)
+
+
+class TestMonitorExecutionModel:
+    """Tests for the MonitorExecution model"""
+
+    @pytest.fixture
+    def monitor_config_key(self, db: Session, monitor_config) -> str:
+        """Returns a monitor config key for testing"""
+        return monitor_config.key
+
+    def test_started_timestamp_is_set_on_creation(
+        self, db: Session, monitor_config_key
+    ) -> None:
+        """Test that the started timestamp is set correctly when creating a new record"""
+        # Create first record
+        first_execution = MonitorExecution.create(
+            db=db,
+            data={
+                "monitor_config_key": monitor_config_key,
+                "status": "running",
+            },
+        )
+
+        # Small delay to ensure timestamps would be different
+        import time
+
+        time.sleep(0.1)
+
+        # Create second record
+        second_execution = MonitorExecution.create(
+            db=db,
+            data={
+                "monitor_config_key": monitor_config_key,
+                "status": "running",
+            },
+        )
+
+        # Verify timestamps are different (not a constant default)
+        assert first_execution.started != second_execution.started
+
+        # Verify timestamps are recent
+        now = datetime.now(timezone.utc)
+        assert (now - first_execution.started).total_seconds() < 5
+        assert (now - second_execution.started).total_seconds() < 5
+
+        # Verify second timestamp is later than first
+        assert second_execution.started > first_execution.started