Skip to content

Commit 9587bf0

Browse files
authored
Fixing data category errors on tests startup (#5877)
1 parent 94f43b6 commit 9587bf0

File tree

1 file changed

+16
-9
lines changed

1 file changed

+16
-9
lines changed

tests/ops/conftest.py

+16-9
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
from fides.api.db.session import get_db_engine, get_db_session
1313
from fides.api.models.sql_models import DataCategory as DataCategoryDbModel
1414
from fides.api.tasks.scheduled.scheduler import async_scheduler, scheduler
15+
from fides.api.util.data_category import get_data_categories_from_db
1516
from tests.conftest import create_citext_extension
1617

1718

@@ -62,17 +63,23 @@ def fideslang_data_categories(db):
6263
"""
6364
Creates a database record for each data category in the fideslang taxonomy.
6465
"""
65-
cats = []
66-
for obj in DEFAULT_TAXONOMY.data_category:
67-
try:
68-
cats.append(DataCategoryDbModel.from_fideslang_obj(obj).save(db))
69-
except IntegrityError:
70-
pass
7166

72-
yield cats
67+
categories = []
68+
existing_categories = get_data_categories_from_db(db)
69+
70+
for default_category in DEFAULT_TAXONOMY.data_category:
71+
if default_category.fides_key not in existing_categories:
72+
try:
73+
categories.append(
74+
DataCategoryDbModel.from_fideslang_obj(default_category).save(db)
75+
)
76+
except IntegrityError:
77+
pass
78+
79+
yield categories
7380

74-
for cat in cats:
81+
for category in categories:
7582
try:
76-
cat.delete(db)
83+
category.delete(db)
7784
except ObjectDeletedError:
7885
pass

0 commit comments

Comments
 (0)