Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Expand Base Model Save #80

Open
pattisdr opened this issue Nov 23, 2022 · 0 comments
Open

Expand Base Model Save #80

pattisdr opened this issue Nov 23, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Nov 23, 2022

Is your feature request related to a specific problem?

Add methods that support asynchronous sessions to be used in separate base model get/create/save/update/delete, etc. methods.

class OrmWrappedFidesBase(FidesBase):

Context https://github.com/ethyca/fidesctl-plus/pull/333#discussion_r1029748992

For context, we now have a model, SystemScans in fides that inherits from the OrmWrappedFidesBase - system scans is normally updated via asynchronous sessions so you need to await the session commit and the session flush, for example. The OrmWrappedFidesBase only has methods that work with synchronous sessions.

Traditionally ops tended to use sync sessions and ctl tended to use async sessions.

Describe the solution you'd like

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@pattisdr pattisdr added the enhancement New feature or request label Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant