You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.
For context, we now have a model, SystemScans in fides that inherits from the OrmWrappedFidesBase - system scans is normally updated via asynchronous sessions so you need to await the session commit and the session flush, for example. The OrmWrappedFidesBase only has methods that work with synchronous sessions.
Traditionally ops tended to use sync sessions and ctl tended to use async sessions.
Describe the solution you'd like
Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a specific problem?
Add methods that support asynchronous sessions to be used in separate base model get/create/save/update/delete, etc. methods.
fideslib/fideslib/db/base_class.py
Line 84 in 1f91d36
Context https://github.com/ethyca/fidesctl-plus/pull/333#discussion_r1029748992
For context, we now have a model,
SystemScans
infides
that inherits from the OrmWrappedFidesBase - system scans is normally updated via asynchronous sessions so you need to await the session commit and the session flush, for example. The OrmWrappedFidesBase only has methods that work with synchronous sessions.Traditionally ops tended to use sync sessions and ctl tended to use async sessions.
Describe the solution you'd like
Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: