Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Disabling a Connector Deletes the Description #1384

Open
pattisdr opened this issue Sep 23, 2022 · 0 comments
Open

Disabling a Connector Deletes the Description #1384

pattisdr opened this issue Sep 23, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@pattisdr
Copy link
Contributor

pattisdr commented Sep 23, 2022

Bug Description

Disabling a webhook from the UI overwrites the description.

A request is sent to the backend with a description in the request body. On the backend, the description is Optional and serialized as null, which overwrites any existing description.

I'd just add the description to the request body here.

Steps to Reproduce

Take a connector that has a description and disable it.

The API will send

PATCH http://0.0.0.0:8080/api/v1/connection
{
  "access": "write"
  "connection_type": "manual_webhook"
  "disabled": true
  "key": "karens_computer"
  "name": "Karen's Computer"
}

Expected behavior

A description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • Version:
  • OS:
  • Python Version:
  • Docker Version:

Additional context

Add any other context about the problem here.

@pattisdr pattisdr added the bug Something isn't working label Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant