-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
White Space Trimming of the DCC Json payload #244
Comments
Dear TSi Any update on this issue, we have some 1000s of Greek DCC affected, and it's causing issues for our validators in Cyprus. |
@psavva brought this to the attention of our developers again to find out how to proceed with this |
Hi @daniel-eder, any news? |
@psavva I did not receive any update on it yet, but I am bringing it up again today |
@daniel-eder, we still facing this issue, and would really need advise how to proceed as we are utilizing the Template applications. Please may I ask that this is reviewed, we have raised this impacting issue almost a month ago, with no response from TSi developers. @SchulzeStTSI Please can you advise on this? |
@psavva The latest update I got is that this issue was reviewed and a developer suggested a potential fix / way forward. |
Our developers just brought me up to speed, the android app uses https://github.com/ehn-dcc-development/dgc-business-rules/tree/main/certlogic for the validation and they are working with the assumption that the whitespace cleanup happens or should happen in that libarary. @dslmeinte can you weigh in on this? Should we move the issue over there, or are additional steps necessary before handing over data to the library? Thank you for your help! |
@daniel-eder Any updates? Whitespace cleanup isn't happening, of course :) |
@daniel-eder Sorry, I missed the ping. Any whitespace cleanup should be part of the standardised DCC framework. Specifically, it should be defined in a new version of this document: https://ec.europa.eu/health/sites/default/files/ehealth/docs/covid-certificate_json_specification_en.pdf Is re-issuing those couple of Ks of DCCs an option? |
@dslmeinte thank you for your input, it makes sense to introduce this on a spec level and not just ad hoc. |
Some countries (GR so far) have produced Payloads which include trailing spaces within the json payload values.
eg: space "mp": "EU/1/20/1528 "
Notice the empty space after the 1528.
1000s of such certificates are uncovered by foreigners causing invalidations,
Recommendation is to trim all whitespaces when executing business rules validations in the verifier apps
The text was updated successfully, but these errors were encountered: