Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White Space Trimming of the DCC Json payload #244

Open
psavva opened this issue Nov 19, 2021 · 10 comments
Open

White Space Trimming of the DCC Json payload #244

psavva opened this issue Nov 19, 2021 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@psavva
Copy link

psavva commented Nov 19, 2021

Some countries (GR so far) have produced Payloads which include trailing spaces within the json payload values.

eg: space "mp": "EU/1/20/1528 "
Notice the empty space after the 1528.

1000s of such certificates are uncovered by foreigners causing invalidations,

Recommendation is to trim all whitespaces when executing business rules validations in the verifier apps

@psavva psavva added the bug Something isn't working label Nov 19, 2021
@psavva
Copy link
Author

psavva commented Nov 22, 2021

Dear TSi

Any update on this issue, we have some 1000s of Greek DCC affected, and it's causing issues for our validators in Cyprus.

@daniel-eder
Copy link
Member

@psavva brought this to the attention of our developers again to find out how to proceed with this

@psavva
Copy link
Author

psavva commented Nov 24, 2021

Hi @daniel-eder, any news?

@daniel-eder
Copy link
Member

@psavva I did not receive any update on it yet, but I am bringing it up again today

@psavva
Copy link
Author

psavva commented Dec 15, 2021

@daniel-eder, we still facing this issue, and would really need advise how to proceed as we are utilizing the Template applications.
We can go ahead and implement a fix ourselves, but i'm not certain that it should be done.

Please may I ask that this is reviewed, we have raised this impacting issue almost a month ago, with no response from TSi developers.

@SchulzeStTSI Please can you advise on this?

@daniel-eder
Copy link
Member

@psavva The latest update I got is that this issue was reviewed and a developer suggested a potential fix / way forward.
Apparently this was not approved yet, but I just requested that the persons involved look at it again or provide a status update.

@daniel-eder
Copy link
Member

Our developers just brought me up to speed, the android app uses https://github.com/ehn-dcc-development/dgc-business-rules/tree/main/certlogic for the validation and they are working with the assumption that the whitespace cleanup happens or should happen in that libarary.

@dslmeinte can you weigh in on this? Should we move the issue over there, or are additional steps necessary before handing over data to the library? Thank you for your help!

@psavva
Copy link
Author

psavva commented Dec 21, 2021

@daniel-eder Any updates? Whitespace cleanup isn't happening, of course :)

@dslmeinte
Copy link

@daniel-eder Sorry, I missed the ping.

Any whitespace cleanup should be part of the standardised DCC framework. Specifically, it should be defined in a new version of this document: https://ec.europa.eu/health/sites/default/files/ehealth/docs/covid-certificate_json_specification_en.pdf
If whitespace cleanup is made part of the framework, it should be done for backward compatibility only: issued DCCs should adhere to the standard as much as possible. Even with proper standardisation, we're potentially enlarging the problem beyond those couple of Ks of DCCs because parties might come to rely on the whitespace cleanup, despite a backward compatibility notice.

Is re-issuing those couple of Ks of DCCs an option?

@daniel-eder
Copy link
Member

@dslmeinte thank you for your input, it makes sense to introduce this on a spec level and not just ad hoc.
@psavva I'll bring it up with our people that work with the spec, but in order for it to be seriously considered and discussed, it would be good to lobby for it from your end as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants