Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

Fix incorrect advice and update syntax. #16

Open
crashoverride777 opened this issue Jul 18, 2018 · 0 comments
Open

Fix incorrect advice and update syntax. #16

crashoverride777 opened this issue Jul 18, 2018 · 0 comments

Comments

@crashoverride777
Copy link

This awesome guide needs some updates

  1. Use swift 4 Syntax in readme
  2. Protect from dynamism section is incorrect. Adding @objc dynamic is not needed for things such as scroll view delegates.
  3. IBOutlets should always be forced unwrapped, like Xcode does by default, not optionals. Optional outlets is a debugging mess.
  4. self should NOT be used unless required, as I mentioned in my other open issue. Stating self should be used at all times is categorically bad swift advice. This is no longer a matter of preference.
  5. weak self should be handled with strongSelf (until swift 4.2) and not self. Self with single quotations is not supported.

Thanks again for this guide and the effort put in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant