Skip to content

Commit

Permalink
fix jupyter docker build
Browse files Browse the repository at this point in the history
  • Loading branch information
achtsnits committed Sep 7, 2023
1 parent 1a40331 commit 0fe116a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build-and-push-jupyter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,5 @@ jobs:
${{ steps.login-ecr.outputs.registry }}/eurodatacube-jupyter:${{ steps.get_image_tag.outputs.TAG }}
eurodatacube/jupyter:${{ steps.get_image_tag.outputs.TAG }}
build-args: |
DOCKER_TAG=${{ steps.get_image_tag.outputs.TAG }}
DOCKER_TAG=${{ steps.get_image_tag.outputs.TAG }}
BASE_IMAGE_TAG=${{ steps.get_image_tag.outputs.TAG }}
2 changes: 1 addition & 1 deletion Dockerfile-jupyter
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ARG BASE_IMAGE_TAG

FROM 527538141574.dkr.ecr.eu-central-1.amazonaws.com/eoxhub-jupyterlab:2${BASE_IMAGE_TAG}
FROM 527538141574.dkr.ecr.eu-central-1.amazonaws.com/eoxhub-jupyterlab:${BASE_IMAGE_TAG}

# NOTE: this is not a duplication, but a documented workaround
# https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact
Expand Down

0 comments on commit 0fe116a

Please sign in to comment.