Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/thread-bug.t crashes under 5.8.9 + threads #80

Closed
MidLifeXis opened this issue Apr 30, 2013 · 5 comments
Closed

t/thread-bug.t crashes under 5.8.9 + threads #80

MidLifeXis opened this issue Apr 30, 2013 · 5 comments

Comments

@MidLifeXis
Copy link
Contributor

This looks like an interaction where $Variable::Magic::VMG_THREADSAFE returns false, but where B::Hooks::EndOfScope::XS is loaded and assumes that V::M::VMG_THREADSAVE is true.

The user can set

$ENV{B_HOOKS_ENDOFSCOPE_IMPLEMENTATION} = 'PP';

but that causes other tests to fail, because the PP implementation does not implement the necessary featureset.

Update: Method::Signatures uses Data::Alias uses B::Hooks::EndOfScope uses Variable::Magic.

@MidLifeXis
Copy link
Contributor Author

I personally think that this is a B::Hooks::EndOfScope bug. I don't like having the test push way down into Variable::Magic to see what its state is (see https://github.com/MidLifeXis/method-signatures/blob/threadbug_skip/t/thread-bug.t#L24). I suppose that I could mark this as a TODO, but I don't think that will save it from a segfault.

Any thoughts @schwern or @barefootcoder on a good way to address this?

Brian

@MidLifeXis
Copy link
Contributor Author

Related issues:

@barefootcoder
Copy link
Contributor

Any thoughts @schwern or @barefootcoder on a good way to address this?

I don't have any thoughts, personally ... @schwern?

@eserte
Copy link
Contributor

eserte commented Dec 10, 2013

This does not look like it's related to 5.8.9 (see my comment on #92).

pjf added a commit to pjf/method-signatures that referenced this issue Feb 11, 2014
Right now this is preventing Method::Signatures from installing
on any system with a threaded perl.

See GH evalEmpire#92, evalEmpire#80, and assorted tickets on RT.
@barefootcoder
Copy link
Contributor

This should be fixed in 20140224. Please reopen if you still see problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants