Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use two different folders to separate the apps and packages #1459

Open
Neosoulink opened this issue Feb 2, 2022 · 2 comments
Open
Labels

Comments

@Neosoulink
Copy link
Contributor

Suggestion for structure improvement

It will really be intersecting to move the current applications in the packages folder to a dedicated folder (apps for example).

The mono-repo will devoid more conventional and practical to use, to separate the two logics

Something like that:

...
├── apps // Contains the applications of the Platform (which can use packages as dependencies)
|   ...
│   ├── shop-mobile-ionic
│   └── shop-web-angular
├── packages // Contains the packages of the mono-repo (which can be used as dependencies)
|   ... 
│   ├── common
│   └── core
...
@Neosoulink Neosoulink added the type: enhancement ✨ New feature or request label Feb 2, 2022
@evereq
Copy link
Member

evereq commented Feb 2, 2022

Yes, so we have already the same structure in the Gauzy - https://github.com/ever-co/ever-gauzy and it's really cool.
Last time it looks like @vercel/turborepo got a lot of traction as it's very fast and it seems also to support well such structures - https://github.com/vercel/turborepo/tree/main/examples/kitchen-sink (for Gauzy we use Nx with Lerna at the moment)

@Neosoulink
Copy link
Contributor Author

Amazing 🤩!

It probably will require some modifications (and some cup of coffee).
But it seems to me to be a good option to use, to change the project architecture and may also migrate to @vercel/turborepo

It may take time, but it will be a big boost ⚡

@Neosoulink Neosoulink changed the title Use two different folders to separate the apps and packages refactor: use two different folders to separate the apps and packages Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants