Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Validators have empty commission rates instead of being at 0 #29

Open
Esya opened this issue Aug 24, 2021 · 3 comments
Open

Validators have empty commission rates instead of being at 0 #29

Esya opened this issue Aug 24, 2021 · 3 comments

Comments

@Esya
Copy link
Contributor

Esya commented Aug 24, 2021

Original issue here : oasisprotocol/wallet#235

Originally the validators had a default commission schedule showing a 0% fee - but they are now empty in the JSON response. Is this breaking change intentional or is it a bug?

Thanks

@Messer4
Copy link
Collaborator

Messer4 commented Aug 25, 2021

We use oasis-core resp model for CommissionSchedule and it contains omitting of empty fields. If commission never was setted CommissionSchedule will be empty
Could you add default value for CommissionSchedule object according to API scheme?
Or I can add Rates and Bounds fields as mandatory and response object will looks like: {"rates" : [], bounds : []}. But Rates and Bounds still will be empty

@Esya
Copy link
Contributor Author

Esya commented Sep 14, 2021

Are you sure ? On the previous version, fee worked, and it is here in the swagger :
https://github.com/everstake/oasis-explorer/blob/master/swagger/swagger.yml#L956

On my local, older version of oasis-explorer it works :

{
"account_id": "oasis1qqyrlc85h0mz4g00gj7r8pmxsas9yqc4nupaxy4a",
"node_id": "oasis1qpqf5qrpstm5wktkzmmpeshfsnzqku7mfugmnpyr",
"fee": 0,
"escrow_balance": 0,
"escrow_shares": 0,
"general_balance": 1000000000000000,
"delegations_balance": 0,
"day_uptime": 1,
"total_uptime": 3.9389064926399855e-16,
"validate_since": 1631644605,
"media_info": null,
"status": "active",
"blocks_count": 7267,
"signatures_count": 7266
}

But here https://testnet-api.oasismonitor.com/data/validators no validators have this property

@Messer4
Copy link
Collaborator

Messer4 commented Sep 15, 2021

Got it.
You mean fee field in validator struct.
Yeah, now we fully index validator fee history and return it in commission_schedule field.
Fee field is deprecated
Actual tag v1.0.1 https://github.com/everstake/oasis-explorer/releases/tag/v1.0.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants