-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up rebuilds #60
Comments
Another potential way to speed up rebuilds would be to compare the source files over http before we clone the repo. This would allow us to skip the rebuild entirely if no source files have changed. As a bonus this would also be useful for the pull request summarizer, which also does comparisons of files over HTTP. |
(I've updated the title of this issue to state the problem rather than the solution 😄 ) Now that #71 has been merged builds are mostly under 5 minutes, yay! 🎉 I think there is still more time that can be gained in some areas though:
|
Problem
Rebuilds are currently taking an average of about 10 minutes, which is slower than they're coming in, so they get backed up and fall slowly out of sync.
Proposed solution
Most of the time for a rebuild is spent doing a fresh clone of the everypolitician-data (which is multi-GB) and doing a full
bundle install
from scratch. If we switch to using a persistent disk to store a copy of the repo and the bundler dependencies then we can avoid all that overhead and skip straight to doing the actual rebuild.I think it would be prudent to do a test of this locally to check there's nothing unexpected that comes up.
Acceptance criteria
Doing a full rebuild of a country should take seconds rather than minutes.
Prerequisites
#62
The text was updated successfully, but these errors were encountered: