Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Module#refine in everypolitician_extensions.rb #15595

Open
chrismytton opened this issue Nov 21, 2016 · 0 comments
Open

Use Module#refine in everypolitician_extensions.rb #15595

chrismytton opened this issue Nov 21, 2016 · 0 comments

Comments

@chrismytton
Copy link
Contributor

Problem

We're currently monkey patching the Everypolitician module in everypolitician_extensions.rb. These changes are global, so could potentially stand on the toes of other code without realising.

Proposed Solution

Use Module#refine to make changes to the Everypolitician::* classes so that our changes are local to the application.

Acceptance Criteria

Changes that are made to Everypolitician should be scoped to the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant