docs and redo option naming

Author: archiewood

README.md

@@ -17,6 +17,7 @@ This driver is maintained by [Evidence](https://evidence.dev): Publish BI report
 - **Explore DB** tables and columns in the sidebar
 - **View** table results by selecting them in the sidebar
 - **Autocomplete** for common keywords (e.g. SELECT, FROM, WHERE) and table names
+- **Read/Write** connections
 
 ### Connect Local and In-Memory DBs
 
@@ -35,6 +36,16 @@ This driver is maintained by [Evidence](https://evidence.dev): Publish BI report
 
 ![Autocomplete](https://github.com/evidence-dev/sqltools-duckdb-driver/blob/master/docs/images/autocomplete.gif?raw=true)
 
+### Read/Write Connections
+
+DuckDB has two access modes:
+1. **Read/Write:** One process can both read and write to the database.
+2. **Read Only:** Multiple processes can read from the database, but no processes can write. 
+
+If you open another connection to a database that is already open in read/write mode, you may get an error. Close the read/write connection to resolve this.
+
+[More Info](https://duckdb.org/faq#how-does-duckdb-handle-concurrency)
+
 ## Not Supported
 - Loading extensions not included in the [default Node.js installation](#DuckDB-Extensions-Supported)
 

connection.schema.json

@@ -13,11 +13,11 @@
       "type": "string",
       "minLength": 1
     },
-    "readWrite": {
-      "title": "Enable Read/Write",
-      "type": "boolean",
-      "default": false,
-      "description": "Note: Read/Write connections prevent other connections until they are closed."
+    "accessMode":{
+      "title": "Access Mode",
+      "type": "string",
+      "enum": ["Read Only", "Read/Write"],
+      "default": "Read Only"
     }
   }
 }

src/ls/driver.ts

@@ -30,10 +30,9 @@ export default class DuckDBDriver extends AbstractDriver<DriverLib, DriverOption
       return this.connection;
     }  
     try {
-      // const mode = this.credentials.databaseFilePath !== ':memory:' ? OPEN_READONLY : OPEN_READWRITE;  
       var mode = null;
 
-      if( this.credentials.readWrite || this.credentials.databaseFilePath === ':memory:') {
+      if( this.credentials.accessMode === "Read/Write" || this.credentials.databaseFilePath === ':memory:') {
         mode = OPEN_READWRITE;
       } else {
         mode = OPEN_READONLY;
@@ -61,7 +60,7 @@ export default class DuckDBDriver extends AbstractDriver<DriverLib, DriverOption
       const rows = await db.all(query.toString());
       var messages = [];
       if (rows.length === 0) {
-        messages = ['Query executed successfully with, no results were returned.'];
+        messages = ['Query executed successfully, no results returned.'];
         }
       else {
         messages = ["Successfully returned " + rows.length + " rows." ];

ui.schema.json

@@ -1,4 +1,8 @@
 {
   "ui:order": ["database"],
-  "databaseFilePath": { "ui:widget": "file" }
+  "databaseFilePath": { "ui:widget": "file" },
+  "accessMode": {
+    "ui:help": "Warning: Read/Write connections prevent any other connections until they are closed"
+  }
+
 }