fix: do not enable export when sourcing rc file (#553)

evilmartians · Oct 2, 2023 · c8e4b13 · c8e4b13
1 parent 0c19b9b
commit c8e4b13
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/docs/configuration.md b/docs/configuration.md
@@ -243,7 +243,7 @@ pre-commit:
       run: npm run eslint {staged_files}
 ```
 
-Provide a tweak to access `npm` executable the same way you do it in your ~/<shell>rc
+Provide a tweak to access `npm` executable the same way you do it in your ~/<shell>rc.
 
 ```yml
 # lefthook-local.yml
@@ -254,16 +254,25 @@ Provide a tweak to access `npm` executable the same way you do it in your ~/<she
 rc: ~/.lefthookrc
 ```
 
+Or
+
+```yml
+# lefthook-local.yml
+
+# If the path contains spaces, you need to quote it.
+rc: '"${XDG_CONFIG_HOME:-$HOME/.config}/lefthookrc"'
+```
+
+In the rc file, export any new environment variables or modify existing ones.
+
 ```bash
 # ~/.lefthookrc
 
 # An nvm way
-
 export NVM_DIR="$HOME/.nvm"
 [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
 
 # Or maybe just
-
 PATH=$PATH:$HOME/.nvm/versions/node/v15.14.0/bin
 ```
 

diff --git a/internal/templates/hook.tmpl b/internal/templates/hook.tmpl
@@ -5,8 +5,7 @@ if [ "$LEFTHOOK" = "0" ]; then
 fi
 
 {{- if .Rc}}
-{{/* Load rc file and export all ENV vars defined in it */}}
-set -a
+{{/* Load rc file, which may export ENV variables */}}
 [ -f {{.Rc}} ] && . {{.Rc}}
 {{- end}}