Install of v1.8.3+ breaks when git version is < 2.31.0

[mwilsoncoding]

🔧 Summary

Today, when installing 1.8.3 or 1.8.4 on a fresh build of a linux container (elixir:1.14.2 in my case <- debian base), I could not boot into my environment due to the following error:

This issue seems to be related.

This other issue also seems related.

After testing, I discovered this is only broken as of v1.8.3

Lefthook version

1.8.3 and 1.8.4

Steps to reproduce

Boot into any devcontainer configured to pull latest lefthook and try to lefthook install

Expected results

Install completes successfully.

Actual results

Error creating directory that already exists.

Possible Solution

I'll have to dig a bit deeper before I have relevant feedback, but answers may lie in this PR that closed the related first issue mentioned above.

For the time being, I'm pinning my lefthook usage at 1.8.2 until this is resolved.

Logs / Screenshots

[mrexox]

Looks like the cause is the recent change - #873, and it looks like old git does not support --path-format=absolute. On elixir:1.14.2 the git version is 2.30.2 when the --path-format firstly appeared in 2.31.0.

Quick fix is to continue using version 1.8.2. I will try to fix this issue for old git versions, but this is probably not a quick fix.

[mwilsoncoding]

That would make sense. Thanks much for taking a deeper look. I'm also looking into updating the base image used in my development environment.

[mwilsoncoding]

I updated the title to more accurately reflect the nature of the issue.

[notramo]

Until a solution is found for older Git, a sensible error message would make developer experience better, e.g. Git version is too old. Minimum supported version is 2.31.0

[cah-brian-gantzler]

I just ran into this as well. Most the docker images I use are based on node 22 using git 2.30.2, but looks like the latest version is using git 2.39.5. Gotta upgrade my docker images