Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Commit

Permalink
feat(ci): add Golang dependency vulnerability check (#1528)
Browse files Browse the repository at this point in the history
* feat(ci): add Golang dependency vulnerability check

* update

* check run

* c++
  • Loading branch information
fedekunze authored Dec 2, 2022
1 parent d9fc677 commit 9077172
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 6 deletions.
28 changes: 28 additions & 0 deletions .github/workflows/dependencies.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: "Dependency Review"
on: pull_request

permissions:
contents: read

jobs:
dependency-review:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v3
with:
go-version: 1.19
check-latest: true
- name: "Checkout Repository"
uses: actions/checkout@v3
- uses: technote-space/[email protected]
with:
PATTERNS: |
**/**.go
go.mod
go.sum
- name: "Dependency Review"
uses: actions/dependency-review-action@v3
if: env.GIT_DIFF
- name: "Go vulnerability check"
run: make vulncheck
if: env.GIT_DIFF
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
args: --timeout 10m
github-token: ${{ secrets.github_token }}
# Check only if there are differences in the source code
if: "env.GIT_DIFF"
if: env.GIT_DIFF
markdown-lint:
name: Run markdown-lint
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Features

- (app) [#1501](https://github.com/evmos/ethermint/pull/1501) Set default File store listener for application from [ADR38](https://docs.cosmos.network/v0.47/architecture/adr-038-state-listening)
* (ci) [#1528](https://github.com/evmos/ethermint/pull/1528) Add Golang dependency vulnerability checker.
* (app) [#1501](https://github.com/evmos/ethermint/pull/1501) Set default File store listener for application from [ADR38](https://docs.cosmos.network/v0.47/architecture/adr-038-state-listening)

### Improvements

Expand Down
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ clean:

all: build

build-all: tools build lint test
build-all: tools build lint test vulncheck

.PHONY: distclean clean build-all

Expand Down Expand Up @@ -273,6 +273,10 @@ go.sum: go.mod
go mod verify
go mod tidy

vulncheck: $(BUILDDIR)/
GOBIN=$(BUILDDIR) go install golang.org/x/vuln/cmd/govulncheck@latest
$(BUILDDIR)/govulncheck ./...

###############################################################################
### Documentation ###
###############################################################################
Expand Down
4 changes: 1 addition & 3 deletions cmd/ethermintd/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ import (
"github.com/evmos/ethermint/version"
)

const (
flagLong = "long"
)
const flagLong = "long"

func init() {
infoCmd.Flags().Bool(flagLong, false, "Print full information")
Expand Down

0 comments on commit 9077172

Please sign in to comment.