28 get sweetest working for getallholontypes api new #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dauphin3
force-pushed
the
28-get-sweetest-working-for-getallholontypes-api-new
branch
from
1476ffc to
755ca65
Compare
|
pulled out types into seperate crate |
nphias
reviewed
Apr 12, 2023
evomimic
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
This PR resolves:
- The sqlite error we were getting that was blocking use of sweettest
- The duplicate num_entry_types error (issue fix duplicate num_entry_types #36 ) that was blocking ALL progress
- and delivers working sweettest results for the getAllHolonTypes API
Great to see us getting past these blockers!
evomimic
deleted the
28-get-sweetest-working-for-getallholontypes-api-new
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.