Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usused code from arduinoledonoffble.ino #122

Open
ghost opened this issue Mar 9, 2015 · 1 comment
Open

Remove usused code from arduinoledonoffble.ino #122

ghost opened this issue Mar 9, 2015 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 9, 2015

The following lines in arduinoledonoffble.ino are not used from what I can see:

Line 11:

#define INPUT_PIN A0

Lines 28-29:

// Writing to an analog input pin sets baseline for later input.
digitalWrite(INPUT_PIN, HIGH);

We should consider the LED to be off when the app sketch loads. Then the user gets a good experience when the LED goes on when using the example app. To do this we would remove these lines 43-44:

// Turn on LED.
digitalWrite(LED_PIN, HIGH);
@ardiri
Copy link

ardiri commented Mar 9, 2015

                                                                                  Or explicitly set it to LOW and comment saying so..// Aaron                                                                                                                                                                                                                                                                                                                                         Sent from my BlackBerry 10 smartphone.                                                                                                                                                                                                                From: Mikael KindborgSent: Monday, March 9, 2015 18:00To: evothings/evothings-examplesReply To: evothings/evothings-examplesSubject: [evothings-examples] Remove usused code from arduinoledonoffble.ino (#122)The following lines in arduinoledonoffble.ino are not used from what I can see:

Line 11:

#define INPUT_PIN A0

Lines 28-29:

// Writing to an analog input pin sets baseline for later input.
digitalWrite(INPUT_PIN, HIGH);

We should consider the LED to be off when the app sketch loads. Then the user gets a good experience when the LED goes on when using the example app. To do this we would remove these lines 43-44:

// Turn on LED.
digitalWrite(LED_PIN, HIGH);

—Reply to this email directly or view it on GitHub.

@ghost ghost self-assigned this Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant