Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Credentials Max Duration #40

Open
bradschwartz opened this issue Jun 11, 2024 · 0 comments
Open

Incorrect Credentials Max Duration #40

bradschwartz opened this issue Jun 11, 2024 · 0 comments

Comments

@bradschwartz
Copy link

Current behavior

It looks like in both adapters the credential_duration_seconds function clamps to a max of 3600 seconds (1 hour) - I'm not sure if this was a previous default of AWS, but assuming this is the correct parameter it looks like AssumeRole has a maximum of 43200 seconds (12 hours).

Expected behavior

I'd expect this function to either:

  1. match the AWS min/max
  2. provide no bounds checking and allow the call to failure from AWS, as max session duration set on a role may still be lower than 3600 seconds and that would still fail today appropriately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant