Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update color drawing #26

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix: update color drawing #26

merged 2 commits into from
Jan 29, 2024

Conversation

Tatehito
Copy link
Collaborator

@Tatehito Tatehito commented Jan 29, 2024

Close #17

セルの色を塗る動作の仕様を以下にしました。

  • new Character()
    • penDown: falseの場合: 塗らない
    • penDown: trueの場合: キャラクターが生まれたセルを塗る
  • moveForward() or moveBack()
    • penDown: falseの場合: 塗らない
    • penDown: trueの場合: 移動先のセルを塗る
  • setColor()
    • penDown: falseの場合: 塗らない
    • penDown: trueの場合: キャラクターのいるセルを塗る
  • upPen()
    • 塗らない
  • putPen()
    • キャラクターがいるセルを塗る

Self Check

  • I've confirmed All checks have passed on PR page. (You may leave this box unchecked due to long workflows.)
    • PR title follows Angular's commit message format.
      • PR title doesn't have WIP:.
    • All tests are passed.
      • Test command (e.g., yarn test) is passed.
      • Lint command (e.g., yarn lint) is passed.
  • I've reviewed my changes on PR's diff view.

@Tatehito Tatehito self-assigned this Jan 29, 2024
@Tatehito Tatehito requested a review from ykit00 January 29, 2024 07:43
Copy link
Collaborator

@ykit00 ykit00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tatehito Tatehito merged commit 304608d into main Jan 29, 2024
8 checks passed
@Tatehito Tatehito deleted the fix/update-color-drawing branch January 29, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ユーザーは実行結果問題に回答できる
2 participants