Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove path property from Character class #29

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Tatehito
Copy link
Collaborator

@Tatehito Tatehito commented Jan 31, 2024

正誤判定からキャラクターの移動の過程を除外し、併せてCharacterクラスからpathを削除しました。

Self Check

  • I've confirmed All checks have passed on PR page. (You may leave this box unchecked due to long workflows.)
    • PR title follows Angular's commit message format.
      • PR title doesn't have WIP:.
    • All tests are passed.
      • Test command (e.g., yarn test) is passed.
      • Lint command (e.g., yarn lint) is passed.
  • I've reviewed my changes on PR's diff view.

@Tatehito Tatehito changed the title fix: Remove unused path property from Character class fix: Remove path property from Character class Jan 31, 2024
@Tatehito Tatehito requested a review from ykit00 January 31, 2024 01:50
@Tatehito Tatehito self-assigned this Jan 31, 2024
Copy link
Collaborator

@ykit00 ykit00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tatehito Tatehito merged commit d3d7063 into main Feb 1, 2024
8 checks passed
@Tatehito Tatehito deleted the fix/remove-character-path branch February 1, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants