Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: fix name problem -> program #35

Merged
merged 2 commits into from
Feb 13, 2024
Merged

refactor: fix name problem -> program #35

merged 2 commits into from
Feb 13, 2024
+6 −6

Conversation

ykit00
Copy link
Collaborator

@ykit00 ykit00 commented Feb 9, 2024 •
edited
Loading

ディレクトリ・ファイル名に使われている problem という表現が problemData.ts で定義されている programIds とでブレていたので program の方に合わせました。

Self Check

  • I've confirmed All checks have passed on PR page. (You may leave this box unchecked due to long workflows.)
    • PR title follows Angular's commit message format.
      • PR title doesn't have WIP:.
    • All tests are passed.
      • Test command (e.g., yarn test) is passed.
      • Lint command (e.g., yarn lint) is passed.
  • I've reviewed my changes on PR's diff view.

@ykit00 ykit00 requested a review from Tatehito February 9, 2024 12:24
@Tatehito
Merge branch 'main' into chore/rename-problem
b97ea31 
# Conflicts:
#	src/app/(withAuth)/programs/[programId]/CheckpointProblem.tsx
#	src/app/(withAuth)/programs/[programId]/ExecutionResultProblem.tsx
#	src/app/(withAuth)/programs/[programId]/StepProblem.tsx
#	src/app/(withAuth)/programs/[programId]/page.tsx
Tatehito
Tatehito approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@Tatehito Tatehito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!コンフリクトは自分の方で対応しておきました

@ykit00 ykit00 merged commit 304f2be into main Feb 13, 2024
7 checks passed
@ykit00 ykit00 deleted the chore/rename-problem branch February 13, 2024 02:36
@ykit00 ykit00 self-assigned this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tatehito Tatehito Tatehito approved these changes

Assignees

@ykit00 ykit00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ykit00 @Tatehito