✅ test: increase code coverage

exactly · Jun 29, 2024 · 0a2cff1 · 0a2cff1
1 parent 36a217d
commit 0a2cff1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/.gas-snapshot b/.gas-snapshot
@@ -4,27 +4,28 @@ MultiOwnerPluginIntegration:test_runtimeValidation_ownerOrSelf_standardExecute()
 MultiOwnerPluginIntegration:test_userOpValidation_owner_standardExecute() (gas: 347849)
 MultiOwnerPluginTest:testFuzz_isValidSignature_ContractOwner(bytes32) (runs: 256, μ: 110118, ~: 110118)
 MultiOwnerPluginTest:testFuzz_isValidSignature_ContractOwnerWithEOAOwner(bytes32) (runs: 256, μ: 120437, ~: 120437)
-MultiOwnerPluginTest:testFuzz_isValidSignature_EOAOwner(string,bytes32) (runs: 256, μ: 130754, ~: 130747)
-MultiOwnerPluginTest:testFuzz_isValidSignature_PasskeyOwner(bytes32) (runs: 256, μ: 365424, ~: 365559)
+MultiOwnerPluginTest:testFuzz_isValidSignature_EOAOwner(string,bytes32) (runs: 256, μ: 130776, ~: 130769)
+MultiOwnerPluginTest:testFuzz_isValidSignature_PasskeyOwner(bytes32) (runs: 256, μ: 365611, ~: 365673)
 MultiOwnerPluginTest:testFuzz_userOpValidationFunction_ContractOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 130892, ~: 130881)
 MultiOwnerPluginTest:testFuzz_userOpValidationFunction_ContractOwnerWithEOAOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 144491, ~: 144480)
 MultiOwnerPluginTest:testFuzz_userOpValidationFunction_EOAOwner(string,(address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 138767, ~: 138770)
-MultiOwnerPluginTest:testFuzz_userOpValidationFunction_PasskeyOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 373615, ~: 373614)
-MultiOwnerPluginTest:test_eip712Domain() (gas: 35394)
-MultiOwnerPluginTest:test_multiOwnerPlugin_sentinelIsNotOwner() (gas: 19794)
-MultiOwnerPluginTest:test_onInstall_failWithInvalidAddress() (gas: 38434)
+MultiOwnerPluginTest:testFuzz_userOpValidationFunction_PasskeyOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 373599, ~: 373588)
+MultiOwnerPluginTest:test_eip712Domain() (gas: 35416)
+MultiOwnerPluginTest:test_isValidSignature_failWithOutOfBounds() (gas: 12263)
+MultiOwnerPluginTest:test_multiOwnerPlugin_sentinelIsNotOwner() (gas: 19816)
+MultiOwnerPluginTest:test_onInstall_failWithInvalidAddress() (gas: 38456)
 MultiOwnerPluginTest:test_onInstall_failWithLimitExceeded() (gas: 1714334)
-MultiOwnerPluginTest:test_onInstall_success() (gas: 94764)
+MultiOwnerPluginTest:test_onInstall_success() (gas: 94786)
 MultiOwnerPluginTest:test_onUninstall_success() (gas: 84935)
 MultiOwnerPluginTest:test_pluginInitializeGuards() (gas: 163889)
-MultiOwnerPluginTest:test_pluginManifest() (gas: 38747)
+MultiOwnerPluginTest:test_pluginManifest() (gas: 38769)
 MultiOwnerPluginTest:test_runtimeValidationFunction_OwnerOrSelf() (gas: 26747)
-MultiOwnerPluginTest:test_updateOwnersPublicKeys_failWithInvalidAddress() (gas: 55749)
+MultiOwnerPluginTest:test_updateOwnersPublicKeys_failWithInvalidAddress() (gas: 55685)
 MultiOwnerPluginTest:test_updateOwners_failWithDuplicatedAddresses() (gas: 85472)
-MultiOwnerPluginTest:test_updateOwners_failWithEmptyOwners() (gas: 70734)
+MultiOwnerPluginTest:test_updateOwners_failWithEmptyOwners() (gas: 70689)
 MultiOwnerPluginTest:test_updateOwners_failWithLimitExceeded() (gas: 1924832)
 MultiOwnerPluginTest:test_updateOwners_failWithNotExist() (gas: 58568)
-MultiOwnerPluginTest:test_updateOwners_failWithZeroAddressOwner() (gas: 56362)
+MultiOwnerPluginTest:test_updateOwners_failWithZeroAddressOwner() (gas: 56384)
 MultiOwnerPluginTest:test_updateOwners_success() (gas: 119826)
 WebauthnModularAccountFactoryTest:test_2StepOwnershipTransfer() (gas: 87560)
 WebauthnModularAccountFactoryTest:test_addStake() (gas: 106151)

diff --git a/test/WebauthnOwnerPlugin.t.sol b/test/WebauthnOwnerPlugin.t.sol
@@ -20,7 +20,7 @@ import { Utils, WebAuthnInfo } from "webauthn-sol/../test/Utils.sol";
 import { WebAuthn } from "webauthn-sol/WebAuthn.sol";
 
 import { DeployScript } from "../script/Deploy.s.sol";
-import { OwnersLib } from "../src/OwnersLib.sol";
+import { IndexOutOfBounds, OwnersLib } from "../src/OwnersLib.sol";
 import { IWebauthnOwnerPlugin, MAX_OWNERS, PublicKey, WebauthnOwnerPlugin } from "../src/WebauthnOwnerPlugin.sol";
 
 import { TestLib } from "./utils/TestLib.sol";
@@ -308,6 +308,11 @@ contract MultiOwnerPluginTest is Test {
     assertEq(_1271_MAGIC_VALUE, plugin.isValidSignature(digest, signature));
   }
 
+  function test_isValidSignature_failWithOutOfBounds() external {
+    vm.expectRevert(IndexOutOfBounds.selector);
+    plugin.isValidSignature("", abi.encodePacked(uint8(4), ""));
+  }
+
   function test_runtimeValidationFunction_OwnerOrSelf() external {
     // should pass with owner as sender
     plugin.runtimeValidationFunction(