Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 in site]: site web manifest issues #2812

Open
dshovchko opened this issue Dec 9, 2024 · 1 comment
Open

[🐛 in site]: site web manifest issues #2812

dshovchko opened this issue Dec 9, 2024 · 1 comment

Comments

@dshovchko
Copy link
Collaborator

Some issues exist with the web manifest file. They can be visible in Chrome Dev Tools, Application section, Manifest tab.

sshot_2024-12-09-12-25-09

As you can see properties name, short_name, and URL are absent and the browser is warning us about this.

I've been exploring the use of these properties - mobile apps use them to create shortcuts, but also on the home screen, etc.

Also there is missing one icon rendition. This is an innovation of 2024. This is 512×512 maskable icon for different Android launchers.

Some resources will be useful for fixing this issue:

@dshovchko dshovchko added the waits triage Issue that waits to be reviewed and handled label Dec 9, 2024
@ala-n ala-n added needs assignee and removed waits triage Issue that waits to be reviewed and handled labels Jan 20, 2025
@dshovchko
Copy link
Collaborator Author

We also need to fix the site's favicon.

Image

Now the legacy icon is specified for all sizes. We need to fix it using the following code.

<link rel="icon" href="/favicon.ico" sizes="32x32">
<link rel="apple-touch-icon" href="/assets/favicon/apple-touch-icon.png">
<link rel="icon" href="/assets/favicon/icon.svg" type="image/svg+xml" sizes="any">

The first one is legacy ico with 32 px size. It should be first.
The second is the legacy icon for Apple devices.
The last one is a universal SVG image for any size. It should be last because browsers work that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants