Add event's name validation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanVqz
added a commit
to JuanVqz/signalman
that referenced
this pull request
Aug 7, 2023
You will receive this error message when trying to run the test suite. ``` Error: SignalmanTest#test_it_has_a_version_number: ActiveRecord::StatementInvalid: Could not find table 'signalman_entries' ``` Feel free to merge this pr before this related excid3#5 one
|
Good with me. Should we also add this to the database |
We've been using the event's name to know what kind of event it is. I think we should add the name presence validator, what do you think about it? If should be more validations, please let me know, and also, if the validation is not needed/desired feel free to close the pr.
JuanVqz
force-pushed
the
add-validate-event-name
branch
from
e6c1247
to
8e58586
Compare
Good call, it's done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using the event's name to know what kind of event it is.
I think we should add the name presence validator,
what do you think about it?
If you want to add more validations, please let me know, and also, if the
validation is not needed/desired feel free to close the pr.