Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch tracking #1

Closed
11 tasks done
ErikSchierboom opened this issue Jan 5, 2024 · 32 comments · Fixed by #3 or #36
Closed
11 tasks done

Launch tracking #1

ErikSchierboom opened this issue Jan 5, 2024 · 32 comments · Fixed by #3 or #36
Assignees

Comments

@ErikSchierboom
Copy link
Member

ErikSchierboom commented Jan 5, 2024

Overall documentation for building an Exercism track lives at https://exercism.org/docs/building/tracks/new

This issue helps keep track of the tasks you're working on towards launching this track.

The next steps are:

Once you've finished a task, you can check them in this list.

Questions

Please ask if you have any questions or if anything is confusing!

@GroophyLifefor
Copy link
Member

Hi @ErikSchierboom ,

I am currently preparing for the university entrance exam, which is an important exam that determines my career in Turkey, I will take the exam on June 8th and I don't have much time, I have cut a lot of time, but this is temporary and I will come back and complete the exercises to 20, I just wanted to mention the reason why the process has slowed down.

@ErikSchierboom
Copy link
Member Author

Sure. Good luck!

@GroophyLifefor GroophyLifefor linked a pull request Jun 23, 2024 that will close this issue
@GroophyLifefor
Copy link
Member

It's been 20 exercises, what should we do now?

@ErikSchierboom
Copy link
Member Author

Basically just to follow the steps listed above. So next up would be to setup continuous integration.

@GroophyLifefor
Copy link
Member

Basically just to follow the steps listed above. So next up would be to setup continuous integration.

I had a little familiarity with docker, I could basically do something with it, -although not very detailed-. but I'm really completely stuck on the test.yaml file. i couldn't even test it on my local, i got an error when i tried docker-compose. i'm not clear on how to install wine with yaml, how to bind to unix* and run test cases.

@ErikSchierboom
Copy link
Member Author

You can't test github actions locally, which is admittedly annoying. For CI, we can do two things:

  1. Use a Windows test runner and run the scripts
  2. Use a Linux test runner and use the test runner Docker image I'll have a think

@GroophyLifefor
Copy link
Member

just to be sure, if I write a terminal code that will test all the exercises in the terminal in windows operating system and this terminal's native language is batch language, can we run it as a test-runner? but as I said, batch language natively supports only windows.

@ErikSchierboom
Copy link
Member Author

if I write a terminal code that will test all the exercises in the terminal in windows operating system and this terminal's native language is batch language, can we run it as a test-runner

No, because we can't run Windows docker images in our production environment. But such a script could run in CI, so yes, that would be really helpful.

@GroophyLifefor
Copy link
Member

GroophyLifefor commented Jul 25, 2024

Hi, I made an test-runner experiment and It looks good for now, but the batch language is native to the windows operating system, so it works with the efficiency of an emulator, which means that unfortunately some exercises did not pass the test-runner.

you can see the experimental branch: https://github.com/exercism/batch/tree/test-runner
shell script(Unix* shell script): https://github.com/exercism/batch/blob/test-runner/bin/test-runner.sh
linked called test-runner(batchfile and works on wine): https://github.com/exercism/batch/blob/test-runner/bin/test-runner.bat


here one image which works well:

image


here one which different to windows: (should be all passed)

image


here one which got crashed:

image
image

@ErikSchierboom
Copy link
Member Author

I assume that the failing solutions don't do anything "weird"?

p.s.

I made an test-runner experiment
The test runner name is something we use for, well, test runners, like https://github.com/exercism/batch-test-runner You might want to call this a CI script of test verification script or something to reduce confusion.

@GroophyLifefor
Copy link
Member

I guess I don't understand what you mean, batch is a very complex language (as interpreter) and even an advanced tool like wine can't emulate it as well as windows. Every language works best in its natural environment.

@ErikSchierboom
Copy link
Member Author

Okay, clear.

@iHiD It sounds like the Batch track might not work well on Linux, which is sort of to be expected. Do we still want a test runner, even if that fails for perfectly valid solutions? I also assume that most people doing the Batch track will work on Windows. Do we maybe want to disable the test runner for this track?

@GroophyLifefor
Copy link
Member

Hi @ErikSchierboom , Is there any news to move? @iHiD might not have seen your comment.

@ErikSchierboom
Copy link
Member Author

I'll notify him

@ErikSchierboom
Copy link
Member Author

We've discussed this and we think it's better to just disable the test runner and focus solely on Windows. Can you fix CI to work on Windows and then use your script to verify the exercises?

@GroophyLifefor
Copy link
Member

Well, I'll do as soon as.

@GroophyLifefor
Copy link
Member

@ErikSchierboom
Copy link
Member Author

I have pushed some changes to your branch to setup CI: #41
Whilst CI appears to be succeeding, I don't think that is actually the case.
I see this in the log:

Run bin/verify-exercises.bat
  bin/verify-exercises.bat
  shell: C:\Windows\system3[2](https://github.com/exercism/batch/actions/runs/10281842917/job/28452234171?pr=41#step:3:2)\cmd.EXE /D /E:ON /V:OFF /S /C "CALL "{0}""
The system cannot find the file config.json.

Could you look at that?

@GroophyLifefor
Copy link
Member

@ErikSchierboom Sorry for much push but CI got fixed :)

image

@ErikSchierboom
Copy link
Member Author

@GroophyLifefor Great. Could you purposefully have one example implementation fail one or more tests to see if CI then fails?

@GroophyLifefor
Copy link
Member

@ErikSchierboom it was great, even if the exercise is faulty it continues but since it was in the last exercise the test is completely finished, no problem

image

@ErikSchierboom
Copy link
Member Author

Thanks!

@GroophyLifefor
Copy link
Member

@ErikSchierboom so, is "Setup Continuous Integration" part done? What is the next step?

@ErikSchierboom
Copy link
Member Author

@GroophyLifefor check the steps at https://exercism.org/docs/building/tracks/new to see what needs to be done next

@GroophyLifefor
Copy link
Member

Reference to a pr that about this issue: exercism/cli#1157

@GroophyLifefor
Copy link
Member

@ErikSchierboom Can I start maintaining alone? I think over time people will come, it's hard to find someone at this stage (not launched).

@ErikSchierboom
Copy link
Member Author

Yes that is fine

@GroophyLifefor
Copy link
Member

@ErikSchierboom when https://exercism.org/tracks/batch will be activated?

@ErikSchierboom
Copy link
Member Author

@GroophyLifefor It'll be up in about 10 minutes or so!

@BNAndras
Copy link
Member

BNAndras commented Sep 4, 2024

https://exercism.org/tracks/batch is missing a track icon. Was it supposed to go live already?

@GroophyLifefor
Copy link
Member

https://exercism.org/tracks/batch is missing a track icon. Was it supposed to go live already?

I submitted in exercism/website-icons#179 two weeks ago, It's now fixed, we apologize for the inconvenience

@GroophyLifefor GroophyLifefor self-assigned this Sep 6, 2024
@BNAndras
Copy link
Member

Track is launched so we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants