-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch tracking #1
Comments
Hi @ErikSchierboom , I am currently preparing for the university entrance exam, which is an important exam that determines my career in Turkey, I will take the exam on June 8th and I don't have much time, I have cut a lot of time, but this is temporary and I will come back and complete the exercises to 20, I just wanted to mention the reason why the process has slowed down. |
Sure. Good luck! |
It's been 20 exercises, what should we do now? |
Basically just to follow the steps listed above. So next up would be to setup continuous integration. |
I had a little familiarity with docker, I could basically do something with it, -although not very detailed-. but I'm really completely stuck on the test.yaml file. i couldn't even test it on my local, i got an error when i tried docker-compose. i'm not clear on how to install wine with yaml, how to bind to unix* and run test cases. |
You can't test github actions locally, which is admittedly annoying. For CI, we can do two things:
|
just to be sure, if I write a terminal code that will test all the exercises in the terminal in windows operating system and this terminal's native language is batch language, can we run it as a test-runner? but as I said, batch language natively supports only windows. |
No, because we can't run Windows docker images in our production environment. But such a script could run in CI, so yes, that would be really helpful. |
Hi, I made an test-runner experiment and It looks good for now, but the batch language is native to the windows operating system, so it works with the efficiency of an emulator, which means that unfortunately some exercises did not pass the test-runner. you can see the experimental branch: https://github.com/exercism/batch/tree/test-runner here one image which works well: here one which different to windows: (should be all passed) here one which got crashed: |
I assume that the failing solutions don't do anything "weird"? p.s.
|
I guess I don't understand what you mean, batch is a very complex language (as interpreter) and even an advanced tool like wine can't emulate it as well as windows. Every language works best in its natural environment. |
Okay, clear. @iHiD It sounds like the Batch track might not work well on Linux, which is sort of to be expected. Do we still want a test runner, even if that fails for perfectly valid solutions? I also assume that most people doing the Batch track will work on Windows. Do we maybe want to disable the test runner for this track? |
Hi @ErikSchierboom , Is there any news to move? @iHiD might not have seen your comment. |
I'll notify him |
We've discussed this and we think it's better to just disable the test runner and focus solely on Windows. Can you fix CI to work on Windows and then use your script to verify the exercises? |
Well, I'll do as soon as. |
Here new version: https://github.com/exercism/batch/blob/test-runner/bin/test-runner.bat |
I have pushed some changes to your branch to setup CI: #41
Could you look at that? |
@ErikSchierboom Sorry for much push but CI got fixed :) |
@GroophyLifefor Great. Could you purposefully have one example implementation fail one or more tests to see if CI then fails? |
@ErikSchierboom it was great, even if the exercise is faulty it continues but since it was in the last exercise the test is completely finished, no problem |
Thanks! |
@ErikSchierboom so, is "Setup Continuous Integration" part done? What is the next step? |
@GroophyLifefor check the steps at https://exercism.org/docs/building/tracks/new to see what needs to be done next |
Reference to a pr that about this issue: exercism/cli#1157 |
@ErikSchierboom Can I start maintaining alone? I think over time people will come, it's hard to find someone at this stage (not launched). |
Yes that is fine |
@ErikSchierboom when https://exercism.org/tracks/batch will be activated? |
@GroophyLifefor It'll be up in about 10 minutes or so! |
https://exercism.org/tracks/batch is missing a track icon. Was it supposed to go live already? |
I submitted in exercism/website-icons#179 two weeks ago, It's now fixed, we apologize for the inconvenience |
Track is launched so we can close this issue. |
Overall documentation for building an Exercism track lives at https://exercism.org/docs/building/tracks/new
This issue helps keep track of the tasks you're working on towards launching this track.
The next steps are:
Once you've finished a task, you can check them in this list.
Questions
Please ask if you have any questions or if anything is confusing!
The text was updated successfully, but these errors were encountered: