Skip to content

Commit

Permalink
fix timeouts and update state on Read
Browse files Browse the repository at this point in the history
  • Loading branch information
sauterp committed Nov 18, 2024
1 parent c6d5c7b commit 54fcbc8
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions pkg/resources/sos_bucket_policy/resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func (r *ResourceSOSBucketPolicy) Read(ctx context.Context, req resource.ReadReq
}

// Set timeout.
timeout, diags := state.Timeouts.Create(ctx, config.DefaultTimeout)
timeout, diags := state.Timeouts.Read(ctx, config.DefaultTimeout)
resp.Diagnostics.Append(diags...)
if resp.Diagnostics.HasError() {
return
Expand Down Expand Up @@ -220,6 +220,8 @@ func (r *ResourceSOSBucketPolicy) Read(ctx context.Context, req resource.ReadReq
return
}

state.Policy = jsontypes.NewNormalizedValue(*policy.Policy)

// Save updated state into Terraform state.
resp.Diagnostics.Append(resp.State.Set(ctx, &state)...)

Expand All @@ -241,7 +243,7 @@ func (r *ResourceSOSBucketPolicy) Update(ctx context.Context, req resource.Updat
}

// Set timeout.
timeout, diags := plan.Timeouts.Create(ctx, config.DefaultTimeout)
timeout, diags := plan.Timeouts.Update(ctx, config.DefaultTimeout)
resp.Diagnostics.Append(diags...)
if resp.Diagnostics.HasError() {
return
Expand Down Expand Up @@ -301,7 +303,7 @@ func (r *ResourceSOSBucketPolicy) Delete(ctx context.Context, req resource.Delet
}

// Set timeout.
timeout, diags := state.Timeouts.Create(ctx, config.DefaultTimeout)
timeout, diags := state.Timeouts.Delete(ctx, config.DefaultTimeout)
resp.Diagnostics.Append(diags...)
if resp.Diagnostics.HasError() {
return
Expand Down

0 comments on commit 54fcbc8

Please sign in to comment.