-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't submit PR for new experiment #523
Comments
hey @earcanal do you want to give a go at contributing your experiment to the Version 2.0 library? After you check our the docs, the contributing instructions are here: https://expfactory.github.io/expfactory/contribute You can be the first tester of my tiny-dinosaur-arms-written-docs! |
Haven't quite ported an experiment over to the new world order, but here's my feedback so far on these docs:
|
Thanks! Here are some quick responses:
If you like, if you point me to your repository I can update the contribute docs and help with the work to port your experiment. I think it would be better for your learning to try it first, but if the docs aren't good enough then I need to fix them. Let me know your preference! |
oh and I understand what you mean by borrowing from test -task - yes Experiment Factory v2.0 is very different in that you aren't constrained to the framework etc. Your index.html can be any web-friendly thing. In the case of the experiments, I am just using the old jspsych bits to get a starting set. |
Yeah, sorry, I think I need a few more clues. Here's the repo: https://github.com/earcanal/breath-counting-task. |
awesome! No worries this is all very new. I'm going to go for a quick run, but will be back in a bit to work on this. Very excited to try out your experiment! If there are important things I should know in advance, please post them here to save me some wandering-in-confusion time. |
I've run it with 40+ participants, so hopefully instructions are good. You can keep the keyboard on the desk if it's more comfortable than in your lap! |
I couldn't last for 15 minutes of breathing in and out - but holy cow just a few minutes I felt so relaxed! I'm finishing up the repo now, will send you some links to updated docs after! |
Tada! That was super easy! I'm going to give a go at building a container for it now - the experiment is added to the library here: https://expfactory.github.io/experiments/ Are there other experiments you want to see ported over? To build some kind of battery / mindfullness container? Oh, and I also updated the contribute docs a lot so hopefully it's a lot more clear. It's a slightly different use case to be porting an "old expfactory" experiment to a new one, but I hope I did a good job explaining the details via a general contribution. https://expfactory.github.io/expfactory/contribute I'm going to give a go at the container, and will ping you here when I have something to test. |
okey doke! I built you a container if you want to test it out: https://www.singularity-hub.org/collections/215 I'm working on a Dockerfile (likely not done tonight but in the next few days) for those that have... Windows scream) |
Fantastic. So to make changes, I would now fork https://github.com/expfactory-experiments/breath-counting-task and submit PRs (and I can delete the breath counting repo you started from)?
I get no data when the breath counting task ends :( Web server reports:
More on docs:
What I'd like to do next is replicate my current study, which raises some questions:
|
It's the middle of the night so I need to go back to sleep, but I have answers for all these things! Here are some quick:
We would actually expect 501 if you are running without the endpoint, and on error it (should) just download data to your local machine (akin to test task in the preview). I likely need to test your experiment more thoroughly - could you tell me how to change it so it only takes maybe 10 seconds to do? (aka as short as the test task). I will make the changes to the contribute page!
I'm going to just port them all, I actually was working on the first just now :) If you tell me the ones you want, I'll do them first.
The container will do it for you, when you select more than one in the portal (the container I built for you only has one, so there is no chaining, but with >1 you would select them at the portal, and then they would be chained.
Let me think about this. I think what we would want is a set of variables the user can choose when installing the experiment, and they determine how it is built (with or without instruction). To start, go ahead and give a go at starting to port the task. I'll make a repo under expfactory-experiments for you to PR to (and also give you permission to breath counting task so you can change topics, etc.) More on this tomorrow! TLDR:
Night! |
And just so I can reproduce your error - are you running your own web server, or the container instance? |
okayt I think I reproduced with test task - you must be running this outside of container, here is what I was able to do:
I'll work on a fix for this! |
okay I did a potential fix, and updated the preview https://expfactory-experiments.github.io/breath-counting-task/ The image isn't updated yet (it needs to be rebuild) but let me know if that one works. I'm going to finish up the first survey test next. |
hey @earcanal ! I made you a special testing container, here are complete instructions! https://expfactory.github.io/expfactory/contribute#test-the-experiment and you don't need to build it yourself, you can pull from Singularity Hub (instructions in the link above) and the repository is here. https://www.singularity-hub.org/containers/776 I'm really excited about this - because the test container has the basic expfactory installed in it, so I can actually (in addition to testing) use it as it's own little package manager. So here is pulling the image
and then seeing what experiments are available:
and what I'm going to add is a "build" command, so you would be able to do like:
and then it will generate the container recipe for you! First I'm going to start working on more porting of the surveys soon - let me know if there are a specific set you are using. Taking a quick break now, back later! |
Good news is the preview with your fix worked for me, in that it downloaded a CSV file. If I understand this correctly, this is amazing as anyone with a browser can run the task (i.e. no local expfactory python plumbing required). In terms of my local use case (I forgot where I wrote this), I can just open experiments (and soon surveys) in browser tabs and have the participant move through them in sequence. In more confused news, to test my experiment I absolutely was running it outside of a container, for the following reasons:
:) I think we're talking past each other, and I'm struggling to understand the docs, due to my lack of knowledge. Would it be possible to chat/hack online somewhere so I can ask dumb questions? This would probably be a quicker way for me to get up to speed, and for you to get an idea about the kind of overview docs people are likely to need to engage with the overall deployment patterns. |
As you managed to fix file creation, I guess you worked out how to shorten the breath counting task. For completeness:
Surveys I'm currently using: |
hey @earcanal ! I've totally refactored to use Docker instead, because it's a little more far alone to use with services (and we won't run into some of the issues above). I'm also hoping that the docs are much more clear (and shorter) and thus easier to follow. Specifically, when you said you were scared and didn't understand singularity, this was a huge red flag that prompted this work! So here is a suggested gameplan for you to follow:
This is all beta, so please report any and all issues. For example, the experiments (that I've generated) are both saving and saving a file to the local machine, and likely I'm just doing the post incorrectly. I need a break from working on this, but my next todo will be to fix the bug mentioned above, and I can add those surveys for you. You have a lot of issues open, so I think it might be easiest to close ones related to singularity, and re-open a fresh issue to discuss this updated implementation. |
oup, hold up one second, there is an error rendering the static files (my browser was caching them) |
ok fixed! I think I fixed the download issue too :) It will need just a few minutes to push to docker hub. |
Hi @vsoch. Thanks! I'm also about to go dark on this for a while as I need to develop an new task and run a couple of studies. However, here's some feedback: I'd got somewhere with Docker previously, so I had a running start this time. That meant that I got The questions which immediately come to mind fall under
At this hand-wavy stage, I see myself with With a little time I may be able to contribute some code to complete this use case. I'll be back... |
Sounds like better results than after the first time!
(To answer your other question) the number in the data folder corresponds with an anonymous participant id, so 00000 was the first, 00001 would be the second, etc. I think this was something you asked for a while back? It would be up to the experimenter to have a secure file to do the matching. I'm finishing up a container that will produce the surveys you linked, and I''ll also start to think about customization for the output type and database, It should be fairly easy to do as long as I have a consistent strategy. The "hand to another lab, plug,and go" is one the reasons I like these stupidly simple, flat format "databases," because you can just hand the whole thing over / plug nicely into a program called R. No worries about "going to dark," I'll update you when I have the survey generation container up to speed! |
hey @earcanal ! Just a quick update - I finished up the surveys you needed, they are added to the table: https://expfactory.github.io/experiments/ Good luck with your work! Chat more when you get back! |
I'd like to submit a PR for a new experiment. After merging with upstream, I get the following error when I try to push my fork:
The error message truncates it, but the push is in the GiB range (
2.8G .git/objects/pack
) i.e. above the 100M maximum. I realise this is more of a git(hub) question, but I'd be grateful for any pointers on how to submit the PR, as I haven't managed to resolve the large commit issue after reading this, and this SO post.The text was updated successfully, but these errors were encountered: