[config] Force entitlement paths to be in posix (#2841)

expo · Nov 3, 2020 · 186f155 · 186f155
1 parent 0204b0b
commit 186f155
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/config/package.json b/packages/config/package.json
@@ -45,6 +45,7 @@
     "require-from-string": "^2.0.2",
     "resolve-from": "^5.0.0",
     "semver": "^7.1.3",
+    "slash": "^3.0.0",
     "slugify": "^1.3.4",
     "xcode": "^2.1.0",
     "xml2js": "^0.4.23"

diff --git a/packages/config/src/ios/Entitlements.ts b/packages/config/src/ios/Entitlements.ts
@@ -1,5 +1,6 @@
 import fs from 'fs-extra';
 import path from 'path';
+import slash from 'slash';
 
 import { ExpoConfig } from '../Config.types';
 import { addWarningIOS } from '../WarningAggregator';
@@ -101,13 +102,16 @@ export function getEntitlementsPath(projectRoot: string): string {
   const projectName = getProjectName(projectRoot);
   const productName = getProductName(project);
 
-  const entitlementsRelativePath = path.join(projectName, `${productName}.entitlements`);
-  const entitlementsPath = path.normalize(path.join(projectRoot, 'ios', entitlementsRelativePath));
+  // Use posix formatted path, even on Windows
+  const entitlementsRelativePath = slash(path.join(projectName, `${productName}.entitlements`));
+  const entitlementsPath = slash(
+    path.normalize(path.join(projectRoot, 'ios', entitlementsRelativePath))
+  );
 
   const pathsToDelete: string[] = [];
 
   while (paths.length) {
-    const last = path.normalize(paths.pop()!);
+    const last = slash(path.normalize(paths.pop()!));
     if (last !== entitlementsPath) {
       pathsToDelete.push(last);
     } else {