This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[config] Force ios entitlement paths to be in posix #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
changed the title
|
See this PR what happens with this change + fork when I re-eject on windows after removing the |
EvanBacon
deleted the
@bycedric/fix/config-force-entitlement-paths-in-posix
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix that doesn't do a lot currently, since we disabled ejecting iOS on windows. But this, in combination with this
xcodefork, actually fixes all differences in the iOS files we get from ejecting the same app on both platforms.I'll try to push the fork to upstream, but there isn't a lot of activity in the repo. So we probably need to fork and republish instead.
This would fix (partially, the fork changes arent in here yet) #2675 if we enable ejecting ios on windows again.