Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable hermes debugger on all build variants #33

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Enable hermes debugger on all build variants #33

merged 1 commit into from
Jan 22, 2024

Conversation

Kudo
Copy link

@Kudo Kudo commented Jan 22, 2024

Why

close ENG-11034

How

patch react-native to set HERMES_ENABLE_DEBUGGER for all variants

@linear Linear
Copy link

linear bot commented Jan 22, 2024

ENG-11034 Press 'J' Open debugger does not work on SDK 50

@Kudo Kudo mentioned this pull request Jan 22, 2024
Merged
2 tasks
@Kudo Kudo merged commit 5aa6b72 into exp-latest Jan 22, 2024
2 checks passed
@Kudo Kudo deleted the @kudo/hermes-enable-debugger branch January 22, 2024 15:13
Kudo added a commit to expo/expo that referenced this pull request Jan 22, 2024
@Kudo
[go] fix hermes debugging not enabled on release builds (#26577)
9f9fb89 
# Why

fixed #26044
close ENG-11034

# How

we need to enable hermes debugging feature even on expo-go release
build. previously we did this when generating versioned hermes. since we
now use unversioned variant to serve sdk 50, we should change our way to
enable the hermes debugging feature.

this pr with expo/react-native#33 are to enable
the `HERMES_ENABLE_DEBUGGER` for all variants
note that: this pr would also increase ios build time because we now
building hermes from source.
Kudo added a commit to expo/expo that referenced this pull request Jan 22, 2024
@Kudo
[go] fix hermes debugging not enabled on release builds (#26577)
fa3b79e 
fixed #26044
close ENG-11034

we need to enable hermes debugging feature even on expo-go release
build. previously we did this when generating versioned hermes. since we
now use unversioned variant to serve sdk 50, we should change our way to
enable the hermes debugging feature.

this pr with expo/react-native#33 are to enable
the `HERMES_ENABLE_DEBUGGER` for all variants
note that: this pr would also increase ios build time because we now
building hermes from source.
gabrieldonadel pushed a commit that referenced this pull request Jan 29, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
5a6acf9
gabrieldonadel pushed a commit that referenced this pull request Feb 6, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
7cc0312
gabrieldonadel pushed a commit that referenced this pull request Mar 7, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
710efc0
gabrieldonadel pushed a commit that referenced this pull request Mar 13, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
c53bb0f
alanjhughes pushed a commit that referenced this pull request Mar 21, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
41eb880
alanjhughes pushed a commit that referenced this pull request Mar 27, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
23d807f
alanjhughes pushed a commit that referenced this pull request Apr 2, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
06fb570
alanjhughes pushed a commit that referenced this pull request Apr 8, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
6e34283
alanjhughes pushed a commit that referenced this pull request Apr 11, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
ea0622f
alanjhughes pushed a commit that referenced this pull request Apr 15, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
e78798d
alanjhughes pushed a commit that referenced this pull request Apr 22, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
696474b
alanjhughes pushed a commit that referenced this pull request May 1, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
e22ae42
alanjhughes pushed a commit that referenced this pull request May 2, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
2efd5ec
alanjhughes pushed a commit that referenced this pull request Jun 4, 2024
@Kudo @alanjhughes
Enable hermes debugger on all build variants (#33)
f5c038d
gabrieldonadel pushed a commit that referenced this pull request Jul 2, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
8be526a
gabrieldonadel pushed a commit that referenced this pull request Jul 17, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
9b9d683
gabrieldonadel pushed a commit that referenced this pull request Jul 17, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
2b02a1c
gabrieldonadel pushed a commit that referenced this pull request Jul 17, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
0f27db3
gabrieldonadel pushed a commit that referenced this pull request Aug 5, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
0b266f9
gabrieldonadel pushed a commit that referenced this pull request Aug 16, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
9ee8489
gabrieldonadel pushed a commit that referenced this pull request Aug 22, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
7eff346
gabrieldonadel pushed a commit that referenced this pull request Oct 8, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
82186f7
gabrieldonadel pushed a commit that referenced this pull request Oct 10, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
976cc9f
gabrieldonadel pushed a commit that referenced this pull request Oct 16, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
17f48e9
gabrieldonadel pushed a commit that referenced this pull request Oct 17, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
464af4b
gabrieldonadel pushed a commit that referenced this pull request Oct 23, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
5374d93
gabrieldonadel pushed a commit that referenced this pull request Oct 29, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
b5d8221
gabrieldonadel pushed a commit that referenced this pull request Nov 14, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
c2814c2
gabrieldonadel pushed a commit that referenced this pull request Nov 22, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
ba28e09
gabrieldonadel pushed a commit that referenced this pull request Dec 9, 2024
@Kudo @gabrieldonadel
Enable hermes debugger on all build variants (#33)
31f72e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanjhughes alanjhughes alanjhughes approved these changes

@gabrieldonadel gabrieldonadel gabrieldonadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kudo @gabrieldonadel @alanjhughes